Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(node): update generated spec file to work better for standalone projects #14461

Merged
merged 1 commit into from
Jan 18, 2023

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Jan 18, 2023

This PR improves the default spec for Node server standalone projects.

Current Behavior

Default spec is e2e/src/e2e/e2e.spec.ts since the name e2e is used for standalone projects.

Expected Behavior

Default spec is e2e/src/server/server.spec.ts to make it more clear what the test is for.

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented Jan 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
nx-dev ⬜️ Ignored (Inspect) Jan 18, 2023 at 2:53PM (UTC)

@jaysoo jaysoo requested a review from ndcunningham January 18, 2023 14:53
@jaysoo jaysoo merged commit 5575ae7 into nrwl:master Jan 18, 2023
@jaysoo jaysoo deleted the fix/rename-default-server-e2e-spec-file branch January 18, 2023 15:49
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants