Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): karma setup should be generated correctly for v14 #14459

Merged
merged 1 commit into from
Jan 20, 2023

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Jan 18, 2023

Current Behavior

Incorrect karma setup being generated for v14 apps

Expected Behavior

Generate correct karma setup for v14 apps

@Coly010 Coly010 self-assigned this Jan 18, 2023
@vercel
Copy link

vercel bot commented Jan 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
nx-dev ⬜️ Ignored (Inspect) Jan 19, 2023 at 6:46PM (UTC)

@Coly010 Coly010 force-pushed the angular/fix-karma-setup branch 2 times, most recently from 091a10e to 108c084 Compare January 19, 2023 12:14
@Coly010 Coly010 force-pushed the angular/fix-karma-setup branch from 108c084 to a5172de Compare January 19, 2023 18:45
@Coly010 Coly010 requested a review from leosvelperez January 19, 2023 19:12
@Coly010 Coly010 merged commit 6330d9e into nrwl:master Jan 20, 2023
@Coly010 Coly010 deleted the angular/fix-karma-setup branch January 20, 2023 10:06
FrozenPandaz pushed a commit that referenced this pull request Jan 20, 2023
@github-actions
Copy link

github-actions bot commented Mar 9, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants