Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): fix broken lines and columns import #14394

Merged
merged 1 commit into from
Jan 16, 2023

Conversation

meeroslav
Copy link
Contributor

@meeroslav meeroslav commented Jan 16, 2023

This fixes the issue introduced in the #14293

Current Behavior

Lines and columns has an invalid import (https://www.npmjs.com/package/lines-and-columns) which is causing the docs generator to crash.

Expected Behavior

We should use names import as per library documentation.

Related Issue(s)

Fixes #

@meeroslav meeroslav added type: bug scope: core core nx functionality labels Jan 16, 2023
@meeroslav meeroslav self-assigned this Jan 16, 2023
@vercel
Copy link

vercel bot commented Jan 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
nx-dev ⬜️ Ignored (Inspect) Jan 16, 2023 at 2:36PM (UTC)

@meeroslav meeroslav enabled auto-merge (squash) January 16, 2023 14:37
@meeroslav meeroslav merged commit a70eec8 into nrwl:master Jan 16, 2023
FrozenPandaz pushed a commit that referenced this pull request Jan 17, 2023
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 11, 2023
@meeroslav meeroslav deleted the fix-lines-and-columns branch April 27, 2023 09:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: core core nx functionality type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants