Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(testing): fixed a typo with the 15.5.0 cypress migration warning #14384

Merged
merged 1 commit into from
Jan 20, 2023
Merged

fix(testing): fixed a typo with the 15.5.0 cypress migration warning #14384

merged 1 commit into from
Jan 20, 2023

Conversation

MichaelBagnasco
Copy link
Contributor

The word 'subility' doesn't exist. I'm assuming the original author meant 'subtly'.

Current Behavior

Cypress 12 has lots of breaking changes that might subility break your tests.

Expected Behavior

Cypress 12 has lots of breaking changes that might subtly break your tests.

@vercel
Copy link

vercel bot commented Jan 15, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Jan 17, 2023 at 6:53PM (UTC)

@nx-cloud
Copy link

nx-cloud bot commented Jan 15, 2023 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 7c8151d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 5 targets

Sent with 💌 from NxCloud.

@barbados-clemens barbados-clemens changed the title fix(cypress): fixed a typo with the 15.5.0 cypress migration warning fix(testing): fixed a typo with the 15.5.0 cypress migration warning Jan 17, 2023
barbados-clemens
barbados-clemens approved these changes Jan 17, 2023
View reviewed changes
Copy link
Contributor

@barbados-clemens barbados-clemens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing my typo!

The CI failed on the commit not matching the template.
instead of fix(cypress): the commit should use fix(testing):.

Should just be able to reword you commit and force push your PR with those changes and be good 👍

@MichaelBagnasco
Copy link
Contributor Author

@barbados-clemens fixed!

@FrozenPandaz FrozenPandaz merged commit f8854d7 into nrwl:master Jan 20, 2023
FrozenPandaz pushed a commit that referenced this pull request Jan 20, 2023
@MichaelBagnasco @FrozenPandaz
fix(testing): fixed a typo with the 15.5.0 cypress migration warning (#…
7a48c21 
…14384)

Co-authored-by: Michael Bagnasco <[email protected]>
(cherry picked from commit f8854d7)
@github-actions github-actions bot mentioned this pull request Mar 4, 2023
Closed
@github-actions
Copy link

github-actions bot commented Mar 9, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@barbados-clemens barbados-clemens barbados-clemens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MichaelBagnasco @barbados-clemens @FrozenPandaz