Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): cap inferred max workers count at 8 #14366

Merged
merged 1 commit into from
Jan 13, 2023

Conversation

FrozenPandaz
Copy link
Collaborator

Current Behavior

In CI (within Docker containers) the os.cpus() returns the number of cpus the real OS has which is generally much more than the actual resources that the docker container has. This will then spawn many workers to calculate the project graph which will overwhelm the resources on the docker container and fail to calculate the graph.

Expected Behavior

There's a cap of 8 on the inferred number of workers that we spawn to calculate the graph. This should prevent the container from getting overwhelmed

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented Jan 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Jan 13, 2023 at 10:31PM (UTC)

@FrozenPandaz FrozenPandaz marked this pull request as ready for review January 13, 2023 22:40
@FrozenPandaz FrozenPandaz merged commit ab8197c into nrwl:master Jan 13, 2023
@FrozenPandaz FrozenPandaz deleted the fix-js-workers branch January 13, 2023 23:50
FrozenPandaz added a commit that referenced this pull request Jan 17, 2023
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants