fix(core): add default configuration to nx schema #14298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g` properties Ensure `defaultConfiguration` is available in the schema for `nx.json` so the default `defaultConfiguration` can be set for an executor. The PR [core: merge more target options from targetDefaults](https://github.com/nrwl/nx/pull/12435/files#diff-60e9fd49c694ec24c2e25e3201eeb2f4be115039b4c78218d74d8b73c7b38490) released in version 15.4.3 should have included this change.
…nit tests Ensure `defaultConfiguration` from `targetDefaults` and project `defaultConfiguration` merge behaviour is correct.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@AgentEnder I checked the I would suggest to not add any specific documentation because any supported property of an executor in We could add |
AgentEnder
approved these changes
Jan 12, 2023
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
The
defaultConfigurationproperty for an executor is missing from nx-schema.json properties.Setting the
defaultConfigurationproperty innx.jsonfor an executor does work though.Expected Behavior
The
defaultConfigurationproperty exists in the nx-schema.json properties you don't get anProperty 'defaultConfiguration' is not allowedwarning.core: merge more target options from targetDefaults in release 15.4.3 should have included this change.
Related Issue(s)
Fixes #14214