-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(web): use daemon file-watcher for file-server executors #14284
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
@Cammisuli If the daemon is not available a fallback watcher using I would suggest using |
Also it think it should be considered deprecating the file-server executor in the @nrwl/angular package and migrating usages to the @nrwl/web file-server to reduce code duplication accross the repo. |
4f7229a
to
f7eda68
Compare
Sorry for the incredibly long delay here 😅 The daemon has become much more stable the last couple of months, so having a fallback to use chokidar or parcel isn't needed at the moment. There's still an issue with Stackblitz, but that's a bigger picture beyond the scope of this PR where the core of Nx needs to support wasm. |
Verified that changing dependent projects will rerun the main watch, just as intended 😄 |
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
TODO
Check if daemon is available and fallback to@parcel/watcher
orchokidar
when not available.Current Behavior
file-server
executors of the angular and web package use chokidar to watch the app and lib directoryExpected Behavior
file-server
executors use the daemon file-watcherRelated Issue(s)
Fixes #