feat(node): add templates for nodejs frameworks #14231
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
ndcunningham
force-pushed
the
feat/support-additional-nodejs-framework
branch
from
401a913 to
d00da97
Compare
| // Prompt for bundler webpack / esbuild | ||
| if (schema.framework) { | ||
| // Prompt for bundler webpack / esbuild if framework is provided without '--bundler' | ||
| if (schema.framework && (!schema.bundler || schema.bundler === 'none')) { |
There was a problem hiding this comment.
As discussed, let's skip prompting the bundler and just use esbuild as the default. Users can read the generator options or our docs if they need to change it.
| @@ -77,8 +77,7 @@ | |||
| "bundler": { | |||
| "description": "Bundler which is used to package the application", | |||
| "type": "string", | |||
| "enum": ["esbuild", "webpack"], | |||
| "default": "esbuild" | |||
| "enum": ["esbuild", "webpack", "none"] | |||
There was a problem hiding this comment.
Let's add a default value for esbuild. I don't think we'll support "none" right now, but users can always use "bundle: false" with esbuild to transpile only.
| const app = new koa(); | ||
|
|
||
| app.use(async ctx =>{ | ||
| ctx.body = 'Hello from Nrwl 🐳 API'; |
There was a problem hiding this comment.
Minor: Let's print something like Hello API -- avoid Nrwl since we're trying to promote as "Nx".
I think we also want it in JSON to mimic an API. Like { "message": "Hello API" } or something.
ndcunningham
force-pushed
the
feat/support-additional-nodejs-framework
branch
3 times, most recently
from
1e81777 to
238b3f7
Compare
Now that the ground work has been set for one framework. This PR adds template support for the remaining frameworks
ndcunningham
force-pushed
the
feat/support-additional-nodejs-framework
branch
from
238b3f7 to
27242e5
Compare
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Now that the ground work has been set for one framework. This PR adds template support for the remaining frameworks
Current Behavior
Expected Behavior
Related Issue(s)
Fixes #