Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(angular): remove decorate-angular-cli #14226

Merged
merged 1 commit into from
Jan 9, 2023

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Jan 9, 2023

Current Behavior

We currently decorate the angular cli so that all ng commands get piped to nx.

Expected Behavior

We want Nx to be seen and used as a standalone CLI tool, therefore remove the linking between angular cli + nx

@Coly010 Coly010 self-assigned this Jan 9, 2023
@vercel
Copy link

vercel bot commented Jan 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nx-dev ✅ Ready (Inspect) Visit Preview Jan 9, 2023 at 1:49PM (UTC)

@@ -129,12 +129,11 @@ describe('convert Angular CLI workspace to an Nx workspace', () => {
const updatedPackageJson = readJson('package.json');
expect(updatedPackageJson.description).toEqual('some description');
expect(updatedPackageJson.scripts).toEqual({
ng: 'nx',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we instead change this to something like 'nx': 'nx' or simply remove it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I'm not too certain!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is from what @angular/cli generates?

I think we should leave it alone.

@@ -129,12 +129,11 @@ describe('convert Angular CLI workspace to an Nx workspace', () => {
const updatedPackageJson = readJson('package.json');
expect(updatedPackageJson.description).toEqual('some description');
expect(updatedPackageJson.scripts).toEqual({
ng: 'nx',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is from what @angular/cli generates?

I think we should leave it alone.

@Coly010 Coly010 merged commit a5707c8 into nrwl:master Jan 9, 2023
@Coly010 Coly010 deleted the angular/remove-decorate-cli branch January 9, 2023 21:34
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants