Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(testing): do not add a duplicate tsconfig.spec.json ref #14201

Merged
merged 1 commit into from
Jan 9, 2023

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Jan 6, 2023

Current Behavior

Jest could add a duplicate ref to the spec file in tsconfig.json

See #14167 (comment)

Expected Behavior

Jest could not add a duplicate ref to the spec file in tsconfig.json

@vercel
Copy link

vercel bot commented Jan 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nx-dev ✅ Ready (Inspect) Visit Preview Jan 6, 2023 at 6:39PM (UTC)

@AgentEnder AgentEnder changed the title fix(core): do not add a duplicate tsconfig.spec.json ref fix(testing): do not add a duplicate tsconfig.spec.json ref Jan 9, 2023
@AgentEnder AgentEnder merged commit da4e2a5 into nrwl:master Jan 9, 2023
@vicb
Copy link
Contributor Author

vicb commented Jan 9, 2023

Thanks!

@vicb vicb deleted the jest-fix branch January 9, 2023 16:59
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants