Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vite): do not include vitest types in tsconfig.json #14200

Merged
merged 1 commit into from
Jan 9, 2023

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Jan 6, 2023

The vitest types are already included in tsconfig.spec.json

Current Behavior

vitest types are added to tsconfig.json

They are already in tsconfig.spec.json

Expected Behavior

vitest types are added to tsconfig.json

Related Issue(s)

#14167 (comment)

@vercel
Copy link

vercel bot commented Jan 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Jan 6, 2023 at 6:33PM (UTC)

The vitest types are already included in tsconfig.spec.json
@AgentEnder AgentEnder merged commit 8d382fb into nrwl:master Jan 9, 2023
@vicb vicb deleted the fix-vitest branch January 9, 2023 16:58
@vicb
Copy link
Contributor Author

vicb commented Jan 9, 2023

Thanks!

@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants