Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(node): support nodejs frameworks #14199

Merged

Conversation

ndcunningham
Copy link
Contributor

@ndcunningham ndcunningham commented Jan 6, 2023

Things TODO

  • Fix e2e test that may fail due using prompt to get input from user
  • Separate functions that are inlined into /utils
  • Create tests for --framework

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@ndcunningham ndcunningham requested a review from jaysoo January 6, 2023 17:40
@vercel
Copy link

vercel bot commented Jan 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nx-dev ✅ Ready (Inspect) Visit Preview Jan 6, 2023 at 10:03PM (UTC)

@ndcunningham ndcunningham changed the title feat(node): support nodejs frameworks to handle scaffolding feat(node): support nodejs frameworks Jan 6, 2023
@ndcunningham ndcunningham force-pushed the feat/suppot-nodejs-frameworks branch from 55fda8d to 48d3d17 Compare January 6, 2023 21:55
@ndcunningham ndcunningham merged commit a631af7 into nrwl:master Jan 6, 2023
@ndcunningham ndcunningham deleted the feat/suppot-nodejs-frameworks branch January 6, 2023 22:04
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants