-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(js): add lockfile generator to js plugin #13968
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
meeroslav
force-pushed
the
fix-update-package-json
branch
from
December 22, 2022 22:35
7cf2cc3
to
4db2ab0
Compare
meeroslav
added
scope: core
core nx functionality
scope: js
and removed
scope: core
core nx functionality
labels
Jan 17, 2023
meeroslav
force-pushed
the
fix-update-package-json
branch
from
January 17, 2023 14:58
4db2ab0
to
a97f639
Compare
meeroslav
force-pushed
the
fix-update-package-json
branch
from
January 17, 2023 16:18
ab748a7
to
f5cc240
Compare
jaysoo
approved these changes
Jan 17, 2023
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rework of the functionality that was reverted in the #13962.
The check for
updateBuildableProjectDepsInPackageJson
is now pushed earlier to ensure we don't override the existingpackage.json
withcreatePackageJson
.Current Behavior
Expected Behavior
Related Issue(s)
Fixes #