Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(js): add lockfile generator to js plugin #13968

Merged
merged 5 commits into from
Jan 17, 2023

Conversation

meeroslav
Copy link
Contributor

@meeroslav meeroslav commented Dec 21, 2022

This is a rework of the functionality that was reverted in the #13962.

The check for updateBuildableProjectDepsInPackageJson is now pushed earlier to ensure we don't override the existing package.json with createPackageJson.

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@meeroslav meeroslav self-assigned this Dec 21, 2022
@vercel
Copy link

vercel bot commented Dec 21, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Jan 17, 2023 at 4:49PM (UTC)

@meeroslav meeroslav force-pushed the fix-update-package-json branch from 7cf2cc3 to 4db2ab0 Compare December 22, 2022 22:35
@meeroslav meeroslav added scope: core core nx functionality scope: js and removed scope: core core nx functionality labels Jan 17, 2023
@meeroslav meeroslav force-pushed the fix-update-package-json branch from ab748a7 to f5cc240 Compare January 17, 2023 16:18
@meeroslav meeroslav merged commit 23c2327 into nrwl:master Jan 17, 2023
@meeroslav meeroslav deleted the fix-update-package-json branch January 17, 2023 21:44
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants