-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(react): add missing style preprocessors when using Vite #13600
Merged
barbados-clemens
merged 1 commit into
nrwl:master
from
jaysoo:fix/react-add-style-preprocessor
Dec 2, 2022
Merged
fix(react): add missing style preprocessors when using Vite #13600
barbados-clemens
merged 1 commit into
nrwl:master
from
jaysoo:fix/react-add-style-preprocessor
Dec 2, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jaysoo
force-pushed
the
fix/react-add-style-preprocessor
branch
from
December 2, 2022 19:57
7a6a7df
to
fa1b859
Compare
barbados-clemens
approved these changes
Dec 2, 2022
jaysoo
force-pushed
the
fix/react-add-style-preprocessor
branch
4 times, most recently
from
December 2, 2022 20:29
718e29d
to
81a9d08
Compare
jaysoo
force-pushed
the
fix/react-add-style-preprocessor
branch
2 times, most recently
from
December 2, 2022 20:40
196468c
to
1a5e7a5
Compare
jaysoo
force-pushed
the
fix/react-add-style-preprocessor
branch
from
December 2, 2022 21:08
1a5e7a5
to
db5fa0b
Compare
jaysoo
force-pushed
the
fix/react-add-style-preprocessor
branch
from
December 2, 2022 21:31
db5fa0b
to
4ee8959
Compare
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vite and Vitest requires style preprocessor to be installed in the workspace, which we are missing.
Current Behavior
Adding a React library using
--style=less|scss|styl
results in an error when running tests.Expected Behavior
Tests should pass.
Related Issue(s)
Fixes #