Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): add missing style preprocessors when using Vite #13600

Merged

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Dec 2, 2022

Vite and Vitest requires style preprocessor to be installed in the workspace, which we are missing.

Current Behavior

Adding a React library using --style=less|scss|styl results in an error when running tests.

Expected Behavior

Tests should pass.

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented Dec 2, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nx-dev ✅ Ready (Inspect) Visit Preview Dec 2, 2022 at 9:35PM (UTC)

Copy link
Contributor

@barbados-clemens barbados-clemens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all work except styled-jsx. where it looks like the template is being generated with an invalid setup.

WkMacM1-sCsrJYEb_12021344

@jaysoo jaysoo force-pushed the fix/react-add-style-preprocessor branch from 7a6a7df to fa1b859 Compare December 2, 2022 19:57
@barbados-clemens barbados-clemens enabled auto-merge (squash) December 2, 2022 19:59
@jaysoo jaysoo force-pushed the fix/react-add-style-preprocessor branch 4 times, most recently from 718e29d to 81a9d08 Compare December 2, 2022 20:29
@jaysoo jaysoo force-pushed the fix/react-add-style-preprocessor branch 2 times, most recently from 196468c to 1a5e7a5 Compare December 2, 2022 20:40
@jaysoo jaysoo force-pushed the fix/react-add-style-preprocessor branch from 1a5e7a5 to db5fa0b Compare December 2, 2022 21:08
@jaysoo jaysoo force-pushed the fix/react-add-style-preprocessor branch from db5fa0b to 4ee8959 Compare December 2, 2022 21:31
@barbados-clemens barbados-clemens merged commit 67c7822 into nrwl:master Dec 2, 2022
@jaysoo jaysoo deleted the fix/react-add-style-preprocessor branch December 2, 2022 21:59
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants