Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(angular): log a warning when running make-angular-cli-faster with older or incompatible versions #13591

Conversation

leosvelperez
Copy link
Member

Current Behavior

Running make-angular-cli-faster with an incompatible or an older version (a version that doesn't supports root project) doesn't provide any feedback about it.

Expected Behavior

Running make-angular-cli-faster with an incompatible or an older version a warning is logged providing feedback.

Related Issue(s)

Fixes #

@leosvelperez leosvelperez requested a review from vsavkin December 2, 2022 15:32
@leosvelperez leosvelperez self-assigned this Dec 2, 2022
@vercel
Copy link

vercel bot commented Dec 2, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Dec 5, 2022 at 4:38PM (UTC)

Copy link
Collaborator

@FrozenPandaz FrozenPandaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I understand what these warnings are supposed to do for the user.

@leosvelperez leosvelperez force-pushed the angular/ng-cli-migration-warn-old-version branch from 3be919d to 633d53f Compare December 5, 2022 16:37
@FrozenPandaz FrozenPandaz merged commit 6b8e42a into nrwl:master Dec 5, 2022
@leosvelperez leosvelperez deleted the angular/ng-cli-migration-warn-old-version branch December 5, 2022 16:52
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants