Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): always set root version of npm packages #13552

Merged
merged 1 commit into from
Dec 2, 2022

Conversation

wSedlacek
Copy link
Contributor

Current Behavior

Root level depednencies are being missed when versions match submodules

Expected Behavior

Root level dependencies should always match the package.json

@vercel
Copy link

vercel bot commented Dec 1, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nx-dev ✅ Ready (Inspect) Visit Preview Dec 1, 2022 at 5:53PM (UTC)

Copy link
Contributor

@meeroslav meeroslav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Looks good to me

@meeroslav meeroslav merged commit 490e945 into nrwl:master Dec 2, 2022
@wSedlacek wSedlacek deleted the hotfix/project-graph-root-deps branch December 2, 2022 08:03
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants