fix(angular): fix root-project support for Angular #13534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Coly010
reviewed
Dec 1, 2022
| @@ -506,6 +506,76 @@ export function tslibC(): string { | |||
| expect(libEslint.overrides[1].extends).toBeUndefined(); | |||
| expect(libEslint.overrides[1].extends).toBeUndefined(); | |||
| }); | |||
|
|
|||
| it('(Angular standalone) should set root project config to app and e2e app and migrate when another lib is added', () => { | |||
There was a problem hiding this comment.
@meeroslav Standalone means something different in angular. (Standalone components and APIs etc) This would probably be better titled something like Angular root-project
There was a problem hiding this comment.
It's a test in the linter e2e and matches our preset name so I would leave this as is, but I'll rename the PR.
meeroslav
changed the title
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Expected Behavior
Related Issue(s)
Fixes #