Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react-native): skipPackageJson was being ignored #13513

Merged

Conversation

ndcunningham
Copy link
Contributor

@ndcunningham ndcunningham commented Nov 30, 2022

Current Behavior

When creating a library or application in react-native the skipPackageJson flag was being ignored.

Expected Behavior

skipPackageJson should be respected.

Related Issue(s)

Fixes #13325

@ndcunningham ndcunningham self-assigned this Nov 30, 2022
@nx-cloud-staging
Copy link

nx-cloud-staging bot commented Nov 30, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit a76735e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 12 targets

Sent with 💌 from NxCloud.

@vercel
Copy link

vercel bot commented Nov 30, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nx-dev ✅ Ready (Inspect) Visit Preview Nov 30, 2022 at 6:41PM (UTC)

Copy link
Collaborator

@xiongemi xiongemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ndcunningham ndcunningham merged commit 5c10f1c into nrwl:master Nov 30, 2022
@ndcunningham ndcunningham deleted the fix/skip-package-json-react-native branch November 30, 2022 19:46
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@nrwl/react-native:lib / @nrwl/react-native:app skipPackageJson ignored
2 participants