-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(react-native): skipPackageJson was being ignored #13513
Merged
ndcunningham
merged 1 commit into
nrwl:master
from
ndcunningham:fix/skip-package-json-react-native
Nov 30, 2022
Merged
fix(react-native): skipPackageJson was being ignored #13513
ndcunningham
merged 1 commit into
nrwl:master
from
ndcunningham:fix/skip-package-json-react-native
Nov 30, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ndcunningham
force-pushed
the
fix/skip-package-json-react-native
branch
from
November 30, 2022 17:07
1335e6d
to
b0efb99
Compare
ndcunningham
force-pushed
the
fix/skip-package-json-react-native
branch
from
November 30, 2022 17:43
b0efb99
to
97cb5b8
Compare
ndcunningham
force-pushed
the
fix/skip-package-json-react-native
branch
from
November 30, 2022 18:38
97cb5b8
to
a76735e
Compare
xiongemi
approved these changes
Nov 30, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
When creating a library or application in react-native the
skipPackageJson
flag was being ignored.Expected Behavior
skipPackageJson
should be respected.Related Issue(s)
Fixes #13325