Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(angular): rename default ngrx-selector names to match ngrx-standard #13475

Merged

Conversation

michaelbe812
Copy link
Contributor

Current Behavior

Currently the generated ngrx selectors are prefixed with get.

Expected Behavior

The generated selectors should match the default naming convention and be prefixed with select

Related Issue(s)

Fixes #

@leosvelperez this is now the clean state. I will delete the other PR

@vercel
Copy link

vercel bot commented Nov 29, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Nov 29, 2022 at 3:10PM (UTC)

Copy link
Member

@leosvelperez leosvelperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for the contribution!
LGTM! 🎉

@leosvelperez leosvelperez merged commit a4a8d9d into nrwl:master Nov 29, 2022
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants