-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(react): add minimal flag #13446
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Small typo, otherwise LGTM |
jaysoo
requested changes
Nov 28, 2022
@@ -187,6 +187,11 @@ | |||
"enum": ["vite", "webpack"], | |||
"x-prompt": "Which bundler do you want to use to build the application?", | |||
"default": "webpack" | |||
}, | |||
"minimal": { | |||
"description": "Generate a React app with a minial setup. Have inline test support, not separate tests files.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo: minial -> minimal
xiongemi
force-pushed
the
feature/add-minimal-flag-react
branch
from
November 28, 2022 15:45
bd1ddd3
to
bb1610a
Compare
xiongemi
force-pushed
the
feature/add-minimal-flag-react
branch
from
November 28, 2022 15:48
bb1610a
to
3d1ee7b
Compare
xiongemi
force-pushed
the
feature/add-minimal-flag-react
branch
from
November 28, 2022 15:51
3d1ee7b
to
4f78ea7
Compare
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Expected Behavior
Related Issue(s)
Fixes #