Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bundling): remove assets option from vite build #13441

Merged
merged 1 commit into from
Nov 28, 2022

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Nov 28, 2022

  • Does not work well with Vite build and dev-server
  • User can put their files into public/ or add a plugin to copy for them

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@jaysoo jaysoo requested a review from mandarini November 28, 2022 14:35
@vercel
Copy link

vercel bot commented Nov 28, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nx-dev ✅ Ready (Inspect) Visit Preview Nov 28, 2022 at 3:18PM (UTC)

Copy link
Member

@mandarini mandarini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, looks good!!

- Does not work well with Vite build and dev-server
- User can put their files into public/ or add a plugin to copy for them
@jaysoo jaysoo force-pushed the cleanup/vite-remove-assets-option branch from 59c2c21 to 5e549ef Compare November 28, 2022 15:13
@jaysoo jaysoo merged commit 5af4ae0 into nrwl:master Nov 28, 2022
@jaysoo jaysoo deleted the cleanup/vite-remove-assets-option branch November 28, 2022 15:40
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants