Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): set the right project graph node type for e2e project with name e2e #13410

Merged

Conversation

leosvelperez
Copy link
Member

Current Behavior

An e2e project with the name "e2e" is getting classified with a node type "app" and therefore, it shows up in the project graph as an app and not as an e2e project. This can be seen with the Angular and React experimental presets where the initial app is at the root of the workspace and the associated e2e project is named "e2e".

Expected Behavior

An e2e project with the name "e2e" should have a node type of "e2e" and appear in the project graph as an e2e project.

Related Issue(s)

Fixes #

@leosvelperez leosvelperez self-assigned this Nov 25, 2022
@vercel
Copy link

vercel bot commented Nov 25, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nx-dev ✅ Ready (Inspect) Visit Preview Nov 25, 2022 at 7:35PM (UTC)

@FrozenPandaz FrozenPandaz merged commit 7be73d1 into nrwl:master Nov 25, 2022
@leosvelperez leosvelperez deleted the core/root-e2e-project-graph-type branch November 25, 2022 20:14
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants