feat(misc): add support for angular cli workspaces to nx init #13404
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
leosvelperez
force-pushed
the
angular/nx-init
branch
from
18df1e8 to
62a279d
Compare
|
|
||
| if (!options.skipInstall) { | ||
| return () => { | ||
| installPackagesTask(tree); | ||
| formatFilesTask(tree); |
There was a problem hiding this comment.
Why change to using a task?
There was a problem hiding this comment.
Because prettier only gets installed in the line above, in a task. Formatting doesn't work before that. It was wrong before, we can't guarantee prettier was previously installed in the Angular CLI workspace. Angular CLI workspaces don't come with it by default.
There was a problem hiding this comment.
I see.. what if we don't add prettier?
There was a problem hiding this comment.
Adding prettier is an explicit requirement from @vsavkin for this feature, so the files generated/updated in the migration are formatted correctly, and any future generator runs are also formatted correctly. Without it, some generators would generate code where the format is messed up.
There was a problem hiding this comment.
Okay then. 🤔
Let's discuss this more after this PR lands.
leosvelperez
force-pushed
the
angular/nx-init
branch
from
62a279d to
63566ef
Compare
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
The
nx initcommand doesn't support Angular CLI workspaces.Expected Behavior
The
nx initcommand supports Angular CLI workspaces.Related Issue(s)
Fixes #