feat(react): add withModuleFederationForSSR function #13276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Coly010
commented
Nov 20, 2022
Comment on lines
5
to
21
| function determineRemoteUrl(remote: string) { | ||
| const remoteConfiguration = readCachedProjectConfiguration(remote); | ||
| const serveTarget = remoteConfiguration?.targets?.serve; | ||
|
|
||
| if (!serveTarget) { | ||
| throw new Error( | ||
| `Cannot automatically determine URL of remote (${remote}). Looked for property "host" in the project's "serve" target.\n | ||
| You can also use the tuple syntax in your webpack config to configure your remotes. e.g. \`remotes: [['remote1', '//localhost:4201']]\`` | ||
| ); | ||
| } | ||
|
|
||
| const host = serveTarget.options?.host ?? '//localhost'; | ||
| const port = serveTarget.options?.port ?? 4201; | ||
| return `${ | ||
| host.endsWith('/') ? host.slice(0, -1) : host | ||
| }:${port}/remoteEntry.js`; | ||
| } |
There was a problem hiding this comment.
@jaysoo This logic may need to change depending on how the server is launched (if the path to the server's location of remoteEntry.js is not at the root URL for example).
Coly010
force-pushed
the
module-federation/react-with-ssr
branch
from
e2b3aaa to
779d4fc
Compare
Coly010
force-pushed
the
module-federation/react-with-ssr
branch
from
779d4fc to
f39be34
Compare
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Module Federation is not supported in SSR
Expected Behavior
SSR should support Module Federation