feat(core): add migration to update workspace generators to a local plugin #12700

AgentEnder · 2022-10-18T21:10:12Z

Current Behavior

You have to manually create a plugin and move workspace-generators manually.

Expected Behavior

You can run a generator to handle this. nx g @nrwl/nx-plugin:local-plugin-from-tools.

Related Issue(s)

Fixes #

nx-cloud-staging · 2022-10-18T21:10:14Z

☁️ Nx Cloud Report

CI is running/has finished running commands for commit dc4e011. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 12 targets

Sent with 💌 from NxCloud.

vercel · 2022-10-18T21:10:17Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
nx-dev	⬜️ Ignored (Inspect)	Visit Preview		Apr 19, 2023 4:15pm

packages/nx-plugin/.eslintrc.json

packages/nx-plugin/src/generators/local-plugin-from-tools/generator.ts

nx-cloud · 2022-12-23T04:37:04Z

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 7684136. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 8 targets

Sent with 💌 from NxCloud.

FrozenPandaz · 2023-02-24T19:30:49Z

docs/generated/packages/workspace/generators/move.json

@@ -21,11 +21,20 @@
        "description": "The name of the project to move.",
        "x-dropdown": "projects"
      },
+      "newProjectName": {


Remove from schema, keep in types

packages/devkit/testing-pre16.ts

packages/nx-plugin/src/generators/local-plugin-from-tools/generator.ts

FrozenPandaz · 2023-04-06T15:49:08Z

packages/workspace/src/migrations/update-16-0-0/move-workspace-generators-to-local-plugin.ts

+        {},
+        {
+          '@nrwl/nx-plugin': nxVersion,
+          '@types/node': 'latest',


Change to 18.7.1

FrozenPandaz · 2023-04-06T16:22:34Z

packages/workspace/src/generators/workspace-generator/workspace-generator.ts

-  const options = normalizeOptions(schema);
+  const message = stripIndents`Workspace Generators are no longer supported. Instead,
+    Nx now supports executing generators or executors from local plugins. To get 
+    started, install @nrwl/nx-plugin and run \`nx g plugin\`.


We need to make nx g plugin fit the mold for this.

Currently, it generates e2e tests, and placeholder executors and generators.

…plugin

FrozenPandaz · 2023-04-19T17:49:58Z

packages/nx-plugin/src/generators/plugin/plugin.ts

@@ -87,6 +88,7 @@ export async function pluginGenerator(host: Tree, schema: Schema) {
  addDependenciesToPackageJson(
    host,
    {
+      tslib: tsLibVersion,


Use import { addTsLibDependencies } from '@nx/js/src/utils/typescript/add-tslib-dependencies';

FrozenPandaz · 2023-04-19T17:51:01Z

packages/workspace/migrations.json

@@ -89,6 +89,12 @@
      "version": "16.0.0-beta.1",
      "description": "Replace @nrwl/workspace with @nx/workspace",
      "implementation": "./src/migrations/update-16-0-0-add-nx-packages/update-16-0-0-add-nx-packages"
+    },
+    "16-0-0-move-workspace-generators-into-local-plugin": {
+      "version": "16.0.0-beta.3",


Suggested change

"version": "16.0.0-beta.3",

"version": "16.0.0-beta.4",

@nx

Squashed commit of the following: commit a51ac58 Author: Miroslav Jonaš <[email protected]> Date: Thu Apr 20 09:16:45 2023 +0200 fix(core): do not expect each package to have hoisted version in lockfile (nrwl#16393) commit 4a4fc19 Author: Miroslav Jonaš <[email protected]> Date: Thu Apr 20 09:16:32 2023 +0200 fix(core): enforce fixed versions only for apps with createPackageJson (nrwl#16398) commit 8400484 Author: Emily Xiong <[email protected]> Date: Wed Apr 19 20:36:11 2023 -0400 feat(core): update create-nx-plugin to generate cli library (nrwl#15994) commit 16e4061 Author: Craigory Coppola <[email protected]> Date: Wed Apr 19 18:25:41 2023 -0400 feat(devkit): bump support range to be 15 <= x <= 17 (nrwl#16421) commit fc07794 Author: Craigory Coppola <[email protected]> Date: Wed Apr 19 18:07:56 2023 -0400 feat(core): remove deprecated affected commands (nrwl#16349) commit a798576 Author: Craigory Coppola <[email protected]> Date: Wed Apr 19 17:02:34 2023 -0400 fix(misc): pass e2eTestRunner to child preset generator (nrwl#16414) commit 338dc64 Author: Nicholas Cunningham <[email protected]> Date: Wed Apr 19 13:29:31 2023 -0600 feat(nextjs): Add standalone Nextjs option to react selection when running CNW (nrwl#16317) commit 16e115f Author: Emily Xiong <[email protected]> Date: Wed Apr 19 15:03:36 2023 -0400 fix(react-native): log errors for pod install (nrwl#16386) commit 0fc3d44 Author: FrozenPandaz <[email protected]> Date: Wed Apr 19 14:24:10 2023 -0400 chore(misc): publish 16.0.0-beta.4 commit f7ca6e6 Author: Craigory Coppola <[email protected]> Date: Wed Apr 19 14:21:30 2023 -0400 chore(misc): update migration version for workspace-generator (nrwl#16417) commit b3ca503 Author: Craigory Coppola <[email protected]> Date: Wed Apr 19 14:12:09 2023 -0400 fix(core): hide duplicate log entry when displaying generator help (nrwl#16353) commit 9fa6d41 Author: Craigory Coppola <[email protected]> Date: Wed Apr 19 14:06:57 2023 -0400 fix(misc): mark workspace-lint as deprecated in yargs config (nrwl#16385) commit 9c9abaa Author: Emily Xiong <[email protected]> Date: Wed Apr 19 14:03:45 2023 -0400 fix(react-native): remove listDevices default value for run-android (nrwl#16410) commit 1743ff1 Author: Craigory Coppola <[email protected]> Date: Wed Apr 19 14:03:00 2023 -0400 feat(core): add migration to update workspace generators to a local plugin (nrwl#12700) commit f04f316 Author: Jack Hsu <[email protected]> Date: Wed Apr 19 14:00:24 2023 -0400 feat(react): add rspack experimental support (nrwl#16252) commit 1ff450b Author: Jason Jean <[email protected]> Date: Wed Apr 19 13:43:44 2023 -0400 fix(core): fix devkit compatibility (nrwl#16413) commit 6677a9c Author: Leosvel Pérez Espinosa <[email protected]> Date: Wed Apr 19 18:32:51 2023 +0100 feat(misc): expose nx init command flags (nrwl#16287) commit 5d7ad34 Author: Leosvel Pérez Espinosa <[email protected]> Date: Wed Apr 19 18:22:52 2023 +0100 feat(testing): bump ts-jest to 29.1.0 to support typescript 5.x (nrwl#16401) commit a8e85da Author: Dominik Pieper <[email protected]> Date: Wed Apr 19 19:01:50 2023 +0200 feat(testing): export cypressE2EConfigurationGenerator (nrwl#16394) commit 1ad7e3d Author: Caleb Ukle <[email protected]> Date: Wed Apr 19 11:55:11 2023 -0500 fix(testing): nullcheck polyfills in ng component testing (nrwl#16411) commit c963393 Author: Katerina Skroumpelou <[email protected]> Date: Wed Apr 19 19:34:38 2023 +0300 fix(storybook): dont use swc addon on sb7 and format (nrwl#16408) commit c8960b7 Author: Miroslav Jonaš <[email protected]> Date: Wed Apr 19 17:13:10 2023 +0200 fix(linter): don't confuse buildable libs for secondary ng entry point (nrwl#16367) commit 2734401 Author: FrozenPandaz <[email protected]> Date: Wed Apr 19 11:10:19 2023 -0400 chore(misc): publish 16.0.0-beta.3 commit da158bc Author: Jason Jean <[email protected]> Date: Wed Apr 19 10:59:58 2023 -0400 feat(angular): replace usages of @nrwl with @nx (nrwl#16377) Co-authored-by: Colum Ferry <[email protected]> commit 76dfc62 Author: Jason Jean <[email protected]> Date: Wed Apr 19 10:59:41 2023 -0400 feat(web): replace usages of @nrwl with @nx (nrwl#16376) commit 1780aac Author: Jack Hsu <[email protected]> Date: Wed Apr 19 10:57:34 2023 -0400 feat(react): add @nx/web as a dependency since it is needed by cypress/etc. (nrwl#16407) commit 52acf07 Author: Jason Jean <[email protected]> Date: Wed Apr 19 10:40:37 2023 -0400 fix(angular): fix resolve builder in ngcli adapter (nrwl#16375) commit ab609a2 Author: Jack Hsu <[email protected]> Date: Wed Apr 19 10:38:01 2023 -0400 fix(js): update swc options so path mappings can work in all environments (nrwl#16390) commit 157b35b Author: Katerina Skroumpelou <[email protected]> Date: Wed Apr 19 17:33:10 2023 +0300 fix(storybook): do not override existing v7 on init (nrwl#16405)

github-actions · 2023-04-25T00:07:03Z

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

vercel bot had a problem deploying to Preview October 18, 2022 21:13 Failure

AgentEnder commented Oct 18, 2022

View reviewed changes

packages/nx-plugin/.eslintrc.json Outdated Show resolved Hide resolved

packages/nx-plugin/src/generators/local-plugin-from-tools/generator.ts Outdated Show resolved Hide resolved

AgentEnder force-pushed the feat/migrate-to-nx-plugins branch from 2e041b5 to 4416668 Compare October 18, 2022 21:14

AgentEnder requested a review from FrozenPandaz October 18, 2022 21:15

vercel bot had a problem deploying to Preview October 18, 2022 21:18 Failure

AgentEnder force-pushed the feat/migrate-to-nx-plugins branch from 4416668 to 6adc47d Compare October 18, 2022 22:17

vercel bot had a problem deploying to Preview October 18, 2022 22:21 Failure

AgentEnder force-pushed the feat/migrate-to-nx-plugins branch from 6adc47d to dc4e011 Compare October 18, 2022 23:12

vercel bot deployed to Preview October 18, 2022 23:14 View deployment

FrozenPandaz assigned AgentEnder Oct 26, 2022

AgentEnder force-pushed the feat/migrate-to-nx-plugins branch from dc4e011 to 50f763d Compare December 23, 2022 04:34

vercel bot deployed to Preview December 23, 2022 04:38 View deployment

AgentEnder force-pushed the feat/migrate-to-nx-plugins branch from 50f763d to e1bbfea Compare February 23, 2023 18:38

AgentEnder requested a review from vsavkin as a code owner February 23, 2023 18:38

vercel bot deployed to Preview February 23, 2023 18:42 View deployment

AgentEnder force-pushed the feat/migrate-to-nx-plugins branch from e1bbfea to 081bf59 Compare February 24, 2023 17:16

vercel bot deployed to Preview February 24, 2023 17:19 View deployment

AgentEnder force-pushed the feat/migrate-to-nx-plugins branch from 081bf59 to 5e2ee70 Compare February 24, 2023 19:33

vercel bot deployed to Preview February 24, 2023 19:37 View deployment

FrozenPandaz approved these changes Feb 24, 2023

View reviewed changes

AgentEnder requested review from bcabanes, isaacplmann and juristr as code owners February 24, 2023 21:12

AgentEnder changed the title ~~feat(core): add generator to migrate workspace generators to a local plugin~~ feat(core): add migration to update workspace generators to a local plugin Feb 24, 2023

vercel bot had a problem deploying to Preview February 24, 2023 21:18 Failure

AgentEnder added the target: next major version To be merged for the next major version release label Feb 24, 2023

AgentEnder force-pushed the feat/migrate-to-nx-plugins branch from cb4900a to 492d053 Compare February 24, 2023 21:33

AgentEnder force-pushed the feat/migrate-to-nx-plugins branch from 619e619 to 4172f16 Compare March 21, 2023 22:33

vercel bot deployed to Preview March 21, 2023 22:37 View deployment

AgentEnder force-pushed the feat/migrate-to-nx-plugins branch from 4172f16 to 09af47c Compare April 5, 2023 16:38

AgentEnder requested a review from jaysoo as a code owner April 5, 2023 16:38

vercel bot deployed to Preview April 5, 2023 16:42 View deployment

AgentEnder requested a review from FrozenPandaz April 5, 2023 18:42

AgentEnder removed the target: next major version To be merged for the next major version release label Apr 5, 2023

AgentEnder force-pushed the feat/migrate-to-nx-plugins branch from 09af47c to 4af4310 Compare April 5, 2023 18:52

vercel bot had a problem deploying to Preview April 5, 2023 18:55 Failure

AgentEnder force-pushed the feat/migrate-to-nx-plugins branch from 4af4310 to a10a29d Compare April 5, 2023 19:00

vercel bot deployed to Preview April 5, 2023 19:04 View deployment

AgentEnder force-pushed the feat/migrate-to-nx-plugins branch from a10a29d to d10f2b6 Compare April 6, 2023 15:50

vercel bot deployed to Preview April 6, 2023 15:53 View deployment

FrozenPandaz requested changes Apr 6, 2023

View reviewed changes

AgentEnder force-pushed the feat/migrate-to-nx-plugins branch from d10f2b6 to 8708bf8 Compare April 18, 2023 22:24

vercel bot deployed to Preview April 18, 2023 22:28 View deployment

AgentEnder force-pushed the feat/migrate-to-nx-plugins branch 2 times, most recently from 0824e42 to d3d3532 Compare April 19, 2023 14:04

AgentEnder added 4 commits April 19, 2023 10:58

feat(core): add generator to migrate workspace generators to a local …

8b85fff

…plugin

feat(misc): migrate workspace generators to local-plugins

a458dd7

chore(core): replace workspace-generator command with deprecation notice

69cbefb

feat(core): add deprecation wrapper for workspace-generator

0007d98

AgentEnder force-pushed the feat/migrate-to-nx-plugins branch from d3d3532 to 4032dfb Compare April 19, 2023 14:58

chore(misc): remove new references to @nrwl packages

7684136

AgentEnder force-pushed the feat/migrate-to-nx-plugins branch from 4032dfb to 7684136 Compare April 19, 2023 16:14

FrozenPandaz approved these changes Apr 19, 2023

View reviewed changes

FrozenPandaz merged commit 1743ff1 into nrwl:master Apr 19, 2023

github-actions bot locked as resolved and limited conversation to collaborators Apr 25, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(core): add migration to update workspace generators to a local plugin #12700

feat(core): add migration to update workspace generators to a local plugin #12700

AgentEnder commented Oct 18, 2022 •

edited

Loading

nx-cloud-staging bot commented Oct 18, 2022 •

edited

Loading

vercel bot commented Oct 18, 2022 •

edited

Loading

nx-cloud bot commented Dec 23, 2022 •

edited

Loading

FrozenPandaz Feb 24, 2023

FrozenPandaz Apr 6, 2023

FrozenPandaz Apr 6, 2023

FrozenPandaz Apr 19, 2023

FrozenPandaz Apr 19, 2023

github-actions bot commented Apr 25, 2023

feat(core): add migration to update workspace generators to a local plugin #12700

feat(core): add migration to update workspace generators to a local plugin #12700

Conversation

AgentEnder commented Oct 18, 2022 • edited Loading

Current Behavior

Expected Behavior

Related Issue(s)

nx-cloud-staging bot commented Oct 18, 2022 • edited Loading

☁️ Nx Cloud Report

vercel bot commented Oct 18, 2022 • edited Loading

nx-cloud bot commented Dec 23, 2022 • edited Loading

☁️ Nx Cloud Report

FrozenPandaz Feb 24, 2023

Choose a reason for hiding this comment

FrozenPandaz Apr 6, 2023

Choose a reason for hiding this comment

FrozenPandaz Apr 6, 2023

Choose a reason for hiding this comment

FrozenPandaz Apr 19, 2023

Choose a reason for hiding this comment

FrozenPandaz Apr 19, 2023

Choose a reason for hiding this comment

github-actions bot commented Apr 25, 2023

AgentEnder commented Oct 18, 2022 •

edited

Loading

nx-cloud-staging bot commented Oct 18, 2022 •

edited

Loading

vercel bot commented Oct 18, 2022 •

edited

Loading

nx-cloud bot commented Dec 23, 2022 •

edited

Loading