You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, eslint-plugin-nx relies on @nrwl/workspace, which itself relies on a number of packages including @nrwl/jest. It would be great to remove this dependency so that the transitive dependencies are no longer included
Motivation
In my specific case, I'm using "Nx Core" (not using @nrwl/workspace or any other nrwl plugins), and my environment uses Vitest rather than Jest, so I was surprised to see jest-related dependencies being installed. While this isn't a huge issue, it would be great to cut down on unneeded dependencies.
Suggested Implementation
It appears that @nrwl/workspace is being used for AST, file, and runtime lint utils. It seems reasonably to move these utils into nx and remove the @nrwl/workspace dependency.
The text was updated successfully, but these errors were encountered:
Hey @luxaritas, I totally agree. Some of these should end up in devkit and some should go to linter.
These parts were there historically because TSLint rule is part of the workspace package.
Detaching this would require getting rid of TSLint which is planned for one of the future versions. Unfortunately, it doesn't have a high priority right now.
Out of curiosity, is there a reason why moving the implementation and then importing in (or even re-exporting from) workspace wouldn't work? I suppose that could create some internal complexity/"noise" (particularly re-exports).
Description
Currently, eslint-plugin-nx relies on
@nrwl/workspace
, which itself relies on a number of packages including@nrwl/jest
. It would be great to remove this dependency so that the transitive dependencies are no longer includedMotivation
In my specific case, I'm using "Nx Core" (not using
@nrwl/workspace
or any other nrwl plugins), and my environment uses Vitest rather than Jest, so I was surprised to see jest-related dependencies being installed. While this isn't a huge issue, it would be great to cut down on unneeded dependencies.Suggested Implementation
It appears that
@nrwl/workspace
is being used for AST, file, and runtime lint utils. It seems reasonably to move these utils intonx
and remove the@nrwl/workspace
dependency.The text was updated successfully, but these errors were encountered: