Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support allowJs customization in the rollup executor #11444

Closed
1 task done
fsmaia opened this issue Aug 4, 2022 · 4 comments · Fixed by #16789
Closed
1 task done

Support allowJs customization in the rollup executor #11444

fsmaia opened this issue Aug 4, 2022 · 4 comments · Fixed by #16789
Labels
outdated scope: react Issues related to React support for Nx type: feature

Comments

@fsmaia
Copy link

fsmaia commented Aug 4, 2022

Description

I would like to see tsconfig.json#compilerOptions.allowJs configuration support for the rollup executor, currently, it is hardcoded as false.

Motivation

This flag allows us to produce typings from JS files and import JS files in TS files, which is very useful when migrating large JS repository files to TypeScript gradually.

Suggested Implementation

Keep false as the default value, but use the configured tsconfig.json value when present.

Alternate Implementations

Actually, I would need to understand why it's hardcoded so I can be able to discuss alternate implementations.

@AgentEnder AgentEnder added the scope: react Issues related to React support for Nx label Aug 6, 2022
@fsmaia
Copy link
Author

fsmaia commented Aug 8, 2022

It seems this flag has been hardcoded since its first implementation:
#1907

@jaysoo, @vsavkin, any hints on why it's hardcoded?

@fsmaia
Copy link
Author

fsmaia commented Sep 5, 2022

Up

@fsmaia
Copy link
Author

fsmaia commented Sep 26, 2022

Am I missing something on the issue template or some important info?
Can't believe this hasn't been even replied and it's very common to have hybrid libraries (TS+JS), which currently can't use the rollup executor!

@github-actions
Copy link

github-actions bot commented Jun 5, 2023

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated scope: react Issues related to React support for Nx type: feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants