feat(node): allow executing esm compiled scripts

[bulldog98]

Current Behavior

The @nrwl/node:node executor is not able to execute esm module scripts

Expected Behavior

The @nrwl/node:node executor is able to execute esm module scripts

Fixes: #10565
Fixes: #16036

[nx-cloud]

☁️ Nx Cloud Report

We didn't find any information for the current pull request with the commit e6fdb7f.
You might need to set the 'NX_BRANCH' environment variable in your CI pipeline.

Check the Nx Cloud Github Integration documentation for more information.

---

Sent with 💌 from NxCloud.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
nx-dev	⬜️ Ignored (Inspect)			May 4, 2023 9:45pm

[bulldog98]

Why did the build not run?

[nartc]

@bulldog98 , thank you for the PR. Can you add some e2e tests for this change?

[bulldog98]

@bulldog98 , thank you for the PR. Can you add some e2e tests for this change?

Sure I first did not see there where e2e tests, but found them now.

[bulldog98]

@nartc I was unable to run the e2e test locally, how are they executed?

[nartc]

@bulldog98 I've rebased the branch and kicked off the build which is failing. Can you take a look? To run test locally, you'd need to start local-registry with:

yarn local-registry enable
yarn local-registry start

then run the e2e:

yarn nx e2e e2e-node

[bulldog98]

sure I'm working on fixing the test.

[bulldog98]

@nartc I fixed the e2e test it works now

[StringKe]

I had the same problem.
How can I use this pr to test if it's the same problem?

[bulldog98]

@nartc sorry I had messed up the check to beEqual, but it should be a toContains

[nartc]

@bulldog98 Thanks for the PR. Everything looks good so far. Just one quick question, why did you have the following?

...
const dynamicImport = new Function('specifier', 'return import(specifier)');
...

Would this work as well?

...
function dynamicImport(specifier) {
   return import(specifier);
}

dynamicImport(fileToRun);
...

[luxaritas]

That said, I'm curious why not just import(fileToRun)

[bulldog98]

The problem is that typescript transpiles the import(fileToRun) to require(fileToRun) the same happens with the version of @nartc.

[luxaritas]

The "real" fix would be to change "module" to "es2020" in the tsconfig - that would be a much larger change, but also this implicitly breaks environments that don't support the dynamic import syntax natively instead of explicitly. I think all current supported node versions should though?

[nartc]

@luxaritas yep, that's my concern as well. I also think the real fix is to support ESM across the board. With TS 4.7, we have a more "official" ESM support but we're somewhat waiting for the dust to settle before making substantial changes to all plugins.

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 92aa909. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 8 targets

• nx affected -t e2e-macos --parallel=1 --base= --head=
• nx affected --target=e2e --base=b59a0a1760e3feb1424bd1de9ac6909f0108c373 --head=92aa9095ab68891462ac09e8fd3a7c14d523dd69 --parallel=1
• nx run-many -t check-imports check-commit check-lock-files depcheck --parallel=1 --no-dte
• nx affected --target=build --base=b59a0a1760e3feb1424bd1de9ac6909f0108c373 --head=92aa9095ab68891462ac09e8fd3a7c14d523dd69 --parallel=3
• nx affected --target=test --base=b59a0a1760e3feb1424bd1de9ac6909f0108c373 --head=92aa9095ab68891462ac09e8fd3a7c14d523dd69 --parallel=1
• nx affected --target=lint --base=b59a0a1760e3feb1424bd1de9ac6909f0108c373 --head=92aa9095ab68891462ac09e8fd3a7c14d523dd69 --parallel=3
• nx-cloud record -- nx format:check --base=b59a0a1760e3feb1424bd1de9ac6909f0108c373 --head=92aa9095ab68891462ac09e8fd3a7c14d523dd69
• nx documentation --no-dte

---

Sent with 💌 from NxCloud.

[jaysoo]

We'll merge this fix, and introduce even more functionality to make sure CJS/ESM compatibility is consistent between the different technologies (webpack, esbuild, tsc, swc, etc.). This is a good workaround until then.

[veimox]

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.