From ad6ec996f48e6d280ff0e90751b82530efc060fb Mon Sep 17 00:00:00 2001 From: Craigory Coppola Date: Thu, 6 Apr 2023 11:25:35 -0400 Subject: [PATCH] feat(core): error when a project graph plugin fails (#16095) --- .../nx/src/project-graph/build-project-graph.ts | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/packages/nx/src/project-graph/build-project-graph.ts b/packages/nx/src/project-graph/build-project-graph.ts index fc975f24cccfa..35157faca1432 100644 --- a/packages/nx/src/project-graph/build-project-graph.ts +++ b/packages/nx/src/project-graph/build-project-graph.ts @@ -24,7 +24,6 @@ import { } from '../config/project-graph'; import { readJsonFile } from '../utils/fileutils'; import { NxJsonConfiguration } from '../config/nx-json'; -import { logger } from '../utils/logger'; import { ProjectGraphBuilder } from './project-graph-builder'; import { ProjectConfiguration, @@ -235,15 +234,12 @@ async function updateProjectGraphWithPlugins( try { graph = await plugin.processProjectGraph(graph, context); } catch (e) { - const message = `Failed to process the project graph with "${plugin.name}". This will error in the future!`; - if (process.env.NX_VERBOSE_LOGGING === 'true') { - console.error(e); - logger.error(message); - return graph; - } else { - logger.warn(message); - logger.warn(`Run with NX_VERBOSE_LOGGING=true to see the error.`); + let message = `Failed to process the project graph with "${plugin.name}".`; + if (e instanceof Error) { + e.message = message + '\n' + e.message; + throw e; } + throw new Error(message); } } return graph;