From 5429ba47ec16a6e5e23c016430a187bf02b18f32 Mon Sep 17 00:00:00 2001 From: Colum Ferry Date: Mon, 15 Apr 2024 16:23:11 +0100 Subject: [PATCH] chore(remix): e2e tests should use strings to prevent issues running commands on windows (#22820) --- e2e/remix/tests/nx-remix.test.ts | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/e2e/remix/tests/nx-remix.test.ts b/e2e/remix/tests/nx-remix.test.ts index ae13f5a216bd7..89995097113df 100644 --- a/e2e/remix/tests/nx-remix.test.ts +++ b/e2e/remix/tests/nx-remix.test.ts @@ -118,12 +118,12 @@ describe('Remix E2E Tests', () => { it('should check for un-escaped dollar signs in routes', async () => { await expect(async () => runCLI( - `generate @nx/remix:route --project ${plugin} --path my.route.$withParams.tsx` + `generate @nx/remix:route --project ${plugin} --path="my.route.$withParams.tsx"` ) ).rejects.toThrow(); runCLI( - `generate @nx/remix:route --project ${plugin} --path my.route.\\$withParams.tsx` + `generate @nx/remix:route --project ${plugin} --path="my.route.\\$withParams.tsx"` ); expect(() => @@ -133,7 +133,7 @@ describe('Remix E2E Tests', () => { it('should pass un-escaped dollar signs in routes with skipChecks flag', async () => { await runCommandAsync( - `someWeirdUseCase=route-segment && yarn nx generate @nx/remix:route --project ${plugin} --path my.route.$someWeirdUseCase.tsx --force` + `someWeirdUseCase=route-segment && yarn nx generate @nx/remix:route --project ${plugin} --path="my.route.$someWeirdUseCase.tsx" --force` ); expect(() => @@ -146,12 +146,12 @@ describe('Remix E2E Tests', () => { it('should check for un-escaped dollar signs in resource routes', async () => { await expect(async () => runCLI( - `generate @nx/remix:resource-route --project ${plugin} --path my.route.$withParams.ts` + `generate @nx/remix:resource-route --project ${plugin} --path="my.route.$withParams.ts"` ) ).rejects.toThrow(); runCLI( - `generate @nx/remix:resource-route --project ${plugin} --path my.route.\\$withParams.ts` + `generate @nx/remix:resource-route --project ${plugin} --path="my.route.\\$withParams.ts"` ); expect(() => @@ -161,7 +161,7 @@ describe('Remix E2E Tests', () => { xit('should pass un-escaped dollar signs in resource routes with skipChecks flag', async () => { await runCommandAsync( - `someWeirdUseCase=route-segment && yarn nx generate @nx/remix:resource-route --project ${plugin} --path my.route.$someWeirdUseCase.ts --force` + `someWeirdUseCase=route-segment && yarn nx generate @nx/remix:resource-route --project ${plugin} --path="my.route.$someWeirdUseCase.ts" --force` ); expect(() =>