diff --git a/e2e/node/src/node.test.ts b/e2e/node/src/node.test.ts index d0cfbf504a47d..e8ed0ee3fd8fb 100644 --- a/e2e/node/src/node.test.ts +++ b/e2e/node/src/node.test.ts @@ -232,44 +232,46 @@ describe('Node Applications', () => { } }, 120000); - it('should be able to run es module applications', async () => { + it('should be able to run ESM applications', async () => { const esmapp = uniq('esmapp'); - runCLI(`generate @nrwl/node:app ${esmapp} --linter=eslint`); + runCLI( + `generate @nrwl/node:app ${esmapp} --linter=eslint --framework=none --bundler=webpack` + ); updateJson(`apps/${esmapp}/tsconfig.app.json`, (config) => { config.module = 'esnext'; config.target = 'es2020'; return config; }); updateProjectConfig(esmapp, (config) => { - config.targets.build.executor = '@nrwl/node:webpack'; config.targets.build.options.outputFileName = 'main.mjs'; - config.targets.build.options.webpackConfig = `apps/${esmapp}/webpack.config.js`; - config.targets.serve.executor = '@nrwl/node:node'; - config.targets.serve.options.watch = false; + config.targets.build.options.assets = []; return config; }); updateFile( `apps/${esmapp}/webpack.config.js`, - `module.exports = (config, context) => ({ - ...config, - experiments: { - ...config.experiments, - outputModule: true, - topLevelAwait: true, - }, - output: { - path: config.output.path, - chunkFormat: 'module', - library: { - type: 'module', - }, - }, - })` + ` + const { composePlugins, withNx } = require('@nx/webpack'); + module.exports = composePlugins(withNx(), (config) => { + config.experiments = { + ...config.experiments, + outputModule: true, + topLevelAwait: true, + }; + config.output = { + path: config.output.path, + chunkFormat: 'module', + library: { type: 'module' } + } + return config; + }); + ` ); await runCLIAsync(`build ${esmapp}`); - const { stdout } = await runCLIAsync(`serve ${esmapp}`); - expect(stdout).toBe('Hello World!'); + const p = await runCommandUntil(`serve ${esmapp}`, (output) => { + return output.includes('Hello World'); + }); + p.kill(); }, 300000); }); diff --git a/lerna.json b/lerna.json index 7174f0d00f574..e4c8f8e98e4c1 100644 --- a/lerna.json +++ b/lerna.json @@ -1,10 +1 @@ -{ - "packages": ["build/packages/*", "build/packages/nx/native-packages/*"], - "version": "16.1.0-rc.1", - "granularPathspec": false, - "command": { - "publish": { - "graphType": "all" - } - } -} +{"packages":["build/packages/*","build/packages/nx/native-packages/*"],"version":"16.1.0","granularPathspec":false,"command":{"publish":{"graphType":"all"}}} \ No newline at end of file