feat: Nested projects

[rickvandermey]

• [1181] create folder structure based on where to projects are located in the repository
• feat: issue 1181 resolve some any typings

linked to #1181

at the moment its only possible when the folder has the same name as the lib/app. maybe should go deeper into that to fix that as well

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 18bb367. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 3 targets

• nx run-many --all --parallel --target=build --max-parallel=3
• nx run-many --all --parallel --target=test --max-parallel=3
• nx run-many --all --parallel --target=lint --max-parallel=3

---

Sent with 💌 from NxCloud.

[Cammisuli]

Thanks for the PR @rickvandermey!

I've been testing it, and it appears that there's some weird artifacts that show up in the Nx Examples repo

Notice the 0,1, 2. In the previous view, it just didnt show anything/expand. Lets try and keep those behaviours the same

[rickvandermey]

Thanks for the PR @rickvandermey!

I've been testing it, and it appears that there's some weird artifacts that show up in the Nx Examples repo

Notice the 0,1, 2. In the previous view, it just didnt show anything/expand. Lets try and keep those behaviours the same

That was the note i added, the workspace project key isnt the same as the folder name
"shared-product-types": "libs/shared/product/types", -> "shared-product-types": "libs/shared/product/shared-product-types", that should fix it, thats the last part i have to add.

but because upcoming week i do not have a lot of spare time, I wanted to give you something to review, and maybe co-develop this feature

[Cammisuli]

Ok, I'll reveiw it again once you add that fix in. We shouldn't have to make users change their config to show things in Nx Console. I'm fine with just hiding the project/child nodes if it doesnt match the path.

[rickvandermey]

@Cammisuli I've updated the PR with working folder structure with tasks

[Cammisuli]

Can we add a proper return type rather than any?

[Cammisuli]

This was a bit too confusing because of the variable names, and the modifying nested properties of the projectObject property. I feel like this (or something close to it) would make this a little more readable:

Suggested change

	splittedProject.reduce((r: {[key: string]: string;} & any, e: string, i: number) => {
	if (splittedProject.length -1 > i) {
	return r[e] || (r[e] = {});
	}
	return r[e] || (r[e] = project)
	}, projectsObject)
	for (const [index, pathNode] of splittedProject.entries()) {
	if (splittedProject.length - 1 > index) {
	projectsObject[pathNode] ??= {};
	continue;
	}
	projectsObject[pathNode] ??= project;
	}

[rickvandermey]

This was a bit too confusing because of the variable names, and the modifying nested properties of the projectObject property. I feel like this (or something close to it) would make this a little more readable:

I've tried implementing your code snippet, but it doesn't compile, so i've added functional naming for the parameters.

[Cammisuli]

the variable names were one part of the confusion, but it's still modifying a nested object. There's a bunch of redirection happening with the nested object

[Cammisuli]

See my comments for individual sections. Also, would it be possible to clean up the icons here:

Basically remove the icon if it's a folder and try to open the project if there's no targets (like in assets). Right now both icons open the base package.json file, which doesnt make sense.

[rickvandermey]

See my comments for individual sections. Also, would it be possible to clean up the icons here:

Basically remove the icon if it's a folder and try to open the project if there's no targets (like in assets). Right now both icons open the base package.json file, which doesnt make sense.

I've added the same logic for projects so the same icons apply when a project. when its a folder, it still opens the package.json, I've tried to resolve to workspace.json instead, but have not figured it out (yet). Should be added in next snippet

if (nxProject.root === '') {
  item.contextValue = 'folder';
  return item;
}

[Cammisuli]

I was hoping that with the change of the type in the previous function, that you would remove the any types from here as well 😅

Please make sure all new code are properly typed please 🙂