feat: use vscode settings for shell execution #1134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nx Cloud ReportCI ran the following commands for commit f1f0289. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch
Sent with 💌 from NxCloud. |
AgentEnder
reviewed
Sep 17, 2021
| } catch { | ||
| bashPath = '/bin/bash'; // Default to where bash is usually installed. | ||
| } | ||
| } | ||
| return new ShellExecution(config.displayCommand, { |
There was a problem hiding this comment.
Much Much Simpler than before! 👍
| @@ -1,5 +1,5 @@ | |||
| import { CliTaskDefinition } from './cli-task-definition'; | |||
| import { Task, TaskGroup, TaskScope } from 'vscode'; | |||
| import { ShellExecution, Task, TaskGroup, TaskScope } from 'vscode'; | |||
There was a problem hiding this comment.
Is ShellExecution used somewhere here? I don't see a reference within this file.
Maybe it has side effects?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
This simplies creating the
ShellExecutionclass to use defaults provided by vscode.More information can be found here:
https://code.visualstudio.com/docs/editor/integrated-terminal#_configuring-the-taskdebug-profile
In summary, Nx Console will now use the default terminal profile, OR the profile provided by the
terminal.integrated.automationShell.<platform>setting`Fixes #1093