Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI-Flags component: Use rounded material components #290

Closed
mrmeku opened this issue Oct 22, 2018 · 2 comments
Closed

UI-Flags component: Use rounded material components #290

mrmeku opened this issue Oct 22, 2018 · 2 comments

Comments

@mrmeku
Copy link
Contributor

mrmeku commented Oct 22, 2018

When I was first creating the ui-flags component (the component which renders fields within a particular CLI schematic), Angular material did not yet have its "outline" style form fields (see https://stackblitz.com/edit/angular-uhbbyu?file=app/form-field-label-example.html for an example). Now that it does, we should use it instead of the custom rounded form fields that I hacked together initially. The benefits are not having brittle CSS that can break with angular material releases, using the built-in mat-hint component rather than absolutely positioning our hints per flag type and overall a better UI experience.

This will be an easy change for autocomplete-able, text-based and select flag types. A bit of custom work will need to be done for boolean types (maybe we should just represent these as dropdowns with two items or maybe we do something custom so they remain clickable toggles).

In addition to using outline based form fields the UI forms could use some general UI touchups. Adding more whitespace to increase readability and potentially adding another column to the form for screens which are particularly wide. These and other tweaks can be left to whoever takes on this issue.

@manekinekko
Copy link
Contributor

taking this one.

@mrmeku
Copy link
Contributor Author

mrmeku commented Nov 9, 2018

@mrmeku mrmeku closed this as completed Nov 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants