Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle non existent json service #1361

Merged
merged 2 commits into from
Sep 22, 2022
Merged

Conversation

Cammisuli
Copy link
Member

What it does

Sets the json language service to return undefined. This makes all other places handle the undefined service if it doesnt get created.

Fixes #1359

@nx-cloud
Copy link

nx-cloud bot commented Sep 22, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 984be1b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 3 targets

Sent with 💌 from NxCloud.

@Cammisuli Cammisuli enabled auto-merge (squash) September 22, 2022 18:19
@Cammisuli Cammisuli merged commit 17bfbc6 into master Sep 22, 2022
@Cammisuli Cammisuli deleted the fix-undefined-jsonscervice branch September 22, 2022 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Constant failures 'Request textDocument/documentLink failed'
1 participant