feat: enable running tests in circleci

nrkno · Jun 20, 2019 · 662638d · 662638d
1 parent 9ebde2e
commit 662638d
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 14 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -108,17 +108,17 @@ workflows:
       - Check for vulnerabilities:
           requires:
             - Checkout Code
-      # - Test node-8:
-      #     requires:
-      #       - Checkout Code
-      # - Send Coverage:
-      #     requires:
-      #       - Check for vulnerabilities
-      #       - Test node-8
-      #     filters:
-      #       branches:
-      #         only:
-      #           - master
+      - Test node-8:
+          requires:
+            - Checkout Code
+      - Send Coverage:
+          requires:
+            - Check for vulnerabilities
+            - Test node-8
+          filters:
+            branches:
+              only:
+                - master
       - Git Release:
           requires:
           #   - Send Coverage

diff --git a/src/commands/__tests__/index.spec.ts b/src/commands/__tests__/index.spec.ts
@@ -320,8 +320,7 @@ const commandConverters: CommandTestConverterSet = {
 			'frameIndex': 'index'
 		},
 		propertyAliases: {
-			'filename': (val: any) => ({ val, name: 'fileName' }),
-			// 'hash': (v: string) => ({ val: Buffer.from(v, 'base64').toString('ascii') })
+			'filename': (val: any) => ({ val, name: 'fileName' })
 		}
 	},
 	'MPrp': {

diff --git a/src/commands/__tests__/util.ts b/src/commands/__tests__/util.ts
@@ -66,4 +66,4 @@ export function runTestForCommand (commandParser: CommandParser, commandConverte
 		// TODO - should they be ignored in here, or filtered in the generator project?
 		expect(allowUnknown).toBeTruthy()
 	}
-}
+}
-Original file line number
+Diff line change
@@ Expand Up @@
     		// TODO - should they be ignored in here, or filtered in the generator project?
     		expect(allowUnknown).toBeTruthy()
     	}
-    }
+    }