Skip to content
This repository has been archived by the owner on Apr 8, 2024. It is now read-only.

core-dialog: Prevent background scrolling when open option #616

Closed
eirikbacker opened this issue Aug 13, 2021 · 3 comments · Fixed by #643
Closed

core-dialog: Prevent background scrolling when open option #616

eirikbacker opened this issue Aug 13, 2021 · 3 comments · Fixed by #643
Assignees
Labels

Comments

@eirikbacker
Copy link
Contributor

eirikbacker commented Aug 13, 2021

As a user I want, html/body scrolling to stop when dialog is open - can this be an option core-dialog fixes for me?

@eirikbacker
Copy link
Contributor Author

Wait a minute - maybe this is the solution:
https://ishadeed.com/article/prevent-scroll-chaining-overscroll-behavior/

@skjalgepalg
Copy link
Collaborator

Overscroll-behavior sounds like it should solve this for most cases.

https://caniuse.com/?search=overscroll-behavior

  • Mind that it's only available as opt-in under experimental features in safari and safari on iOS with no apparent polyfill or workaround short of temporarily modding body styles.

@eirikbacker
Copy link
Contributor Author

@skjalgepalg jupp :) maybe mention it in the docs as this is quite a new feature and our users might not be aware of it? as overscroll-behavior is nice to have and not a must, I do not see safari not supporting it (yet) as a blocker :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants