Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] npm-template-check should tell us if templated files have the wrong content #39

Closed
1 task done
nlf opened this issue Feb 1, 2022 · 0 comments · Fixed by #81
Closed
1 task done

[BUG] npm-template-check should tell us if templated files have the wrong content #39

nlf opened this issue Feb 1, 2022 · 0 comments · Fixed by #81
Labels
Needs Triage needs an initial review

Comments

@nlf
Copy link
Contributor

nlf commented Feb 1, 2022

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

if a templated file is manually edited, npm-template-check won't notice (except for the package.json and .gitignore)

Expected Behavior

we should receive an error and the check should fail if other templated files (i.e. ci workflows, eslint config, etc) do not match what they should

Steps To Reproduce

  1. mkdir foo && cd foo && npm init -y
  2. npm i -D @npmcli/template-oss
  3. echo "" >> .github/actions/ci.yml
  4. npm run lint
  5. observe there is no error, despite the ci.yml having a change from the template

Environment

  • npm: 8.4.0
  • Node: 16.13.2
  • OS: osx
  • platform: M1 Macbook Pro
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Triage needs an initial review
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant