Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ignore scripts for all ci installs #106

Merged
merged 1 commit into from
Mar 25, 2022
Merged

feat: ignore scripts for all ci installs #106

merged 1 commit into from
Mar 25, 2022

Conversation

lukekarrys
Copy link
Contributor

No description provided.

@lukekarrys lukekarrys requested a review from a team as a code owner March 23, 2022 21:22
@lukekarrys lukekarrys force-pushed the lk/ignore-scripts branch 2 times, most recently from 7fd02e2 to 8cd81c1 Compare March 23, 2022 22:14
@wraithgar
Copy link
Member

Is this supposed to be based off of the release-please PR?

@nlf
Copy link
Contributor

nlf commented Mar 25, 2022

while we're changing these flags.. should we also consider throwing in a --no-audit --no-fund? we have no need for the install time audits since we have an explicit auditing workflow, and we absolutely never review funding information so printing it in ci isn't of much use

nlf
nlf approved these changes Mar 25, 2022
View reviewed changes
Copy link
Contributor

@nlf nlf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved with a comment that can be addressed (if it's something we're interested in doing) in a separate pull request

@lukekarrys
Copy link
Contributor Author

yeah i think we should. anything to make CI faster is worth it

@lukekarrys lukekarrys merged commit b9c9c95 into main Mar 25, 2022
@lukekarrys lukekarrys deleted the lk/ignore-scripts branch March 25, 2022 18:36
@lukekarrys lukekarrys mentioned this pull request Mar 25, 2022
Closed
@github-actions github-actions bot mentioned this pull request Mar 25, 2022
Merged
@github-actions github-actions bot mentioned this pull request Aug 25, 2022
Closed
@lukekarrys lukekarrys mentioned this pull request Aug 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlf nlf nlf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lukekarrys @wraithgar @nlf