Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[epic] devEngines #861

Closed
7 tasks done
Tracked by #898
wraithgar opened this issue Jun 3, 2024 · 3 comments
Closed
7 tasks done
Tracked by #898

[epic] devEngines #861

wraithgar opened this issue Jun 3, 2024 · 3 comments
Assignees
Labels

Comments

@wraithgar
Copy link
Member

wraithgar commented Jun 3, 2024

Overview

Implement the spec at openjs-foundation/package-metadata-interoperability-collab-space#15

The Plan

Because this has a complete overlap with existing checks we do for installs, npm-install-checks will still be where this logic lives. It will be changed to expect the data in this new format, and things that currently call it will conform their existing calls to that format. Then npm itself can also directly ask npm-install-checks passing it devEngines

The Tasks

@wraithgar wraithgar self-assigned this Jun 3, 2024
@wraithgar wraithgar added the epic label Jun 3, 2024
@ljharb
Copy link

ljharb commented Jun 3, 2024

My understanding is that npm won't implement the download field, and it's not clear if it will implement onFail either - if so, which enum values will it support?

@wraithgar
Copy link
Member Author

It's not clear cause no code has been written. Please be patient.

@ljharb
Copy link

ljharb commented Jun 3, 2024

I just mean the plan isn't clear, no rush tho :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants
@wraithgar @ljharb @reggi and others