Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE(config): --npm-version & --node-version should be removed #575

Closed
3 tasks
Tracked by #443
darcyclarke opened this issue Oct 6, 2022 · 4 comments
Closed
3 tasks
Tracked by #443
Assignees
Labels

Comments

@darcyclarke
Copy link
Contributor

darcyclarke commented Oct 6, 2022

Summary

The --npm-version flag/option is confusing as we also have a top-level command npm version which is not configured by this at all. --npm-version is used by dependencies like npm-pick-manifest & libnpmpublish but not by the CLI itself. If not changed, this may cause issues when we go to implement command-specific configuration.

Exit Criteria

  • remove --npm-version from being user-configurable & hard-code its downstream usage
  • remove --node-version from being user-configurable
  • investigate backporting warnings in v8.x

References

@darcyclarke darcyclarke mentioned this issue Oct 6, 2022
32 tasks
@darcyclarke darcyclarke changed the title BREAKING CHANGE(config): --npm-version should be renamed BREAKING CHANGE(config): --npm-version should be renamed or removed Oct 6, 2022
@wraithgar
Copy link
Member

node-version also

@ljharb
Copy link

ljharb commented Oct 6, 2022

What do those flags even do?

@wraithgar
Copy link
Member

They are used in npm-pick-manifest to sort the packuments so that "working" ones bubble to the top... we are ok losing that imo.
They are used of course in logging engines conflicts and strict-engines checks. Strict engines being configurable is specifically the solution to the problem of mismatching engines, no need to override it there.

Finally it is used by arborist when installing optional dependencies. If the engine/npm versions aren't allowed it skips them.

@darcyclarke darcyclarke changed the title BREAKING CHANGE(config): --npm-version should be renamed or removed BREAKING CHANGE(config): --npm-version should be removed Oct 6, 2022
@darcyclarke darcyclarke changed the title BREAKING CHANGE(config): --npm-version should be removed BREAKING CHANGE(config): --npm-version & --node-version should be removed Oct 6, 2022
@ljharb
Copy link

ljharb commented Oct 6, 2022

So they're overrides for package.json engines data?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants