Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor lib/utils/open-url.js #124

Closed
ruyadorno opened this issue Jun 10, 2020 · 0 comments · Fixed by npm/cli#2772
Closed

refactor lib/utils/open-url.js #124

ruyadorno opened this issue Jun 10, 2020 · 0 comments · Fixed by npm/cli#2772

Comments

@ruyadorno
Copy link

from: npm/cli#1311 (comment)

Note: we should make openUrl return a promise. Also, I see that it checks process.argv explicitly for a --no-browser flag, which is not great. (Should just be checking npm.config.get('browser') === false or better yet, npm.flatOptions.browser === false.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants