Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove references/dependency on process.umask() #119

Closed
2 tasks
darcyclarke opened this issue Jun 1, 2020 · 3 comments
Closed
2 tasks

Remove references/dependency on process.umask() #119

darcyclarke opened this issue Jun 1, 2020 · 3 comments

Comments

@darcyclarke
Copy link
Contributor

darcyclarke commented Jun 1, 2020 •
edited
Loading

  • remove process.umask() from tar (or update tar if it's already removed in latest versions)
  • remove process.umask() everywhere in the cli (ex. lib/utils/config.js)

Node deprecation ref: nodejs/node@60c4c2b6c5
@darcyclarke darcyclarke added this to the OSS - Sprint 8 milestone Jun 1, 2020
@darcyclarke darcyclarke added this to the OSS - Sprint 12 milestone Jul 30, 2020
@darcyclarke darcyclarke removed this from the OSS - Sprint 12 milestone Jul 31, 2020
@darcyclarke darcyclarke added this to the OSS - Sprint 14 milestone Sep 4, 2020
@darcyclarke
Copy link
Contributor Author

Good context on this change/work can be found here: nodejs/node#32321

@darcyclarke darcyclarke changed the title Update tar to no longer rely on process.umask() Update cli to no longer rely on process.umask() Oct 1, 2020
@darcyclarke darcyclarke changed the title Update cli to no longer rely on process.umask() Remove references/dependency on process.umask() Oct 1, 2020
@darcyclarke
Copy link
Contributor Author

Other reference to thread: npm/cli#1103 (comment)

@darcyclarke darcyclarke added this to the OSS - Sprint 16 milestone Oct 1, 2020
@bonkydog
Copy link

bonkydog commented Oct 1, 2020

OK, I'm starting work on this in pacote.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@isaacs @bonkydog @darcyclarke