Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add some fields to the README #180

Merged
merged 1 commit into from
Jun 1, 2022
Merged

docs: add some fields to the README #180

merged 1 commit into from
Jun 1, 2022

Conversation

jablko
Copy link
Contributor

@jablko jablko commented May 26, 2022

Does it make sense to add the manifest _id field and the packument _cached and _contentLength fields to the README, along with the other fields that Pacote adds? That's what this PR does.

@jablko jablko requested a review from a team as a code owner May 26, 2022 15:25
@wraithgar
Copy link
Member

This is pretty good timing because _id came up in #176.

The npm cli already assumes _id is always set when things come back from pacote, it's probably worth documenting.

@wraithgar wraithgar merged commit f356cb2 into npm:main Jun 1, 2022
@github-actions github-actions bot mentioned this pull request Jun 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jablko @wraithgar