-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add checkSignatures to registry.manifest #170
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you pass NO keys for the registry being fetched from, this logic is bypassed. This is so that this flag can be turned on without breaking existing folks who don't have the keys in their config, nor are sending it to pacote in places. |
wraithgar
force-pushed
the
gar/integrity-signature
branch
from
May 12, 2022 16:36
790dfa8
to
008a79e
Compare
nlf
approved these changes
May 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think this looks good!
feelepxyz
reviewed
May 13, 2022
feelepxyz
reviewed
May 13, 2022
feelepxyz
reviewed
May 13, 2022
feelepxyz
reviewed
May 13, 2022
wraithgar
force-pushed
the
gar/integrity-signature
branch
from
May 16, 2022 18:01
008a79e
to
dd2001b
Compare
feelepxyz
reviewed
May 17, 2022
wraithgar
force-pushed
the
gar/integrity-signature
branch
from
May 17, 2022 16:32
dd2001b
to
dac13e2
Compare
wraithgar
added a commit
that referenced
this pull request
May 17, 2022
This was referenced May 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.