Skip to content
This repository has been archived by the owner on Apr 7, 2021. It is now read-only.

fix(index): npx log install result to stdout not in stderr #63

Closed
wants to merge 1 commit into from
Closed

fix(index): npx log install result to stdout not in stderr #63

wants to merge 1 commit into from

Conversation

akaguny
Copy link

@akaguny akaguny commented Jul 2, 2020

BREAKING CHANGE: some automatization may expect old behavior

What / Why

installed is success and will be write to stdout, not in stderr

References

installed is success and will be write to stdout, not in stderr

BREAKING CHANGE: some automatization may expect old behavior
@akaguny akaguny requested a review from a team as a code owner July 2, 2020 11:44
@karfau
Copy link

karfau commented Jul 2, 2020

I would vote against this change:
I believe writing to stdout should be preserved to the tool/package/module that is invoked.
So that the output of the tool (the thing the "npx user" actually cares about) can be piped into a different place.
If the data of the tool is e.g. JSON your change would add that line to the JSON output which leads to a syntax error when trying to read/parse it.

@ljharb
Copy link

ljharb commented Jul 2, 2020

I agree; diagnostic output doesn’t belong on stdout.

@akaguny
Copy link
Author

akaguny commented Jul 9, 2020

anyone in cli team, can you comment?
If change is needed i will complete PR with test issues.
Else i will close PR with comment

@KilianKilmister
Copy link

@akaguny @ljharb
General callout for people potentially interested in collaborating on an npx alternative in light of its unmaintained status.
A project proposal can be found here.

@ljharb
Copy link

ljharb commented Jul 19, 2020

It’s still maintained, and an npx that doesn’t ship with npm is not useful.

@KilianKilmister
Copy link

It’s still maintained, and an npx that doesn’t ship with npm is not useful.

Sure hasn't looked like it is maintained fo a few months now
and i don't see how not shipping with npm has much effect on usability. besides, npm is just another package and can be used as a dependency. and much of what it uses under the hood is awailable in seperate packages aswell, so i really can't agree on your second statement.

Anyways, i've already been intrusive enough. i don't want to take up any more space here for non-npx things

@darcyclarke
Copy link
Contributor

@akaguny thanks for this submission - as @ljharb noted, this repo is going to eventually be archived & we'll be deprecating the package as npx comes with npm by default & the code now solely lives in https://github.com/npm/cli

@akaguny akaguny deleted the bugfix/npx-log-install-result-to-stdout-not-in-stderr branch March 10, 2021 16:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants