Use String.includes() when possible
#675
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kartikjain26
approved these changes
Jan 24, 2020
XhmikosR
changed the title
String.includes() when possibleString.includes() when possible
mikemimik
added
Community
Enhancement
|
Another good change IMO would be to use |
|
@XhmikosR Thanks for the contribution! Unfortunately, these changes land quite a bit of churn into the codebase & we'll actually be refactoring a lot of this out for the next major version of the CLI. We're going to queue up some smaller refactoring issues/tasks for npm |
This was referenced Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMHO this is cleaner and should work with Node.js 6.x and newer, but CI should tell us for sure :)