Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(unpublish): bubble up all errors parsing local package.json #7049

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

wraithgar
Copy link
Member

If the file is there and there is any error that's always a show stopper

@wraithgar wraithgar requested a review from a team as a code owner December 1, 2023 18:38
@wraithgar
Copy link
Member Author

@wraithgar wraithgar force-pushed the gar/unpublish-package-json-errors branch from e93d3ef to 3a42cff Compare December 1, 2023 18:40
If the file is there and there is any error that's always a show stopper
@wraithgar wraithgar force-pushed the gar/unpublish-package-json-errors branch from 3a42cff to 82809a9 Compare December 1, 2023 18:40
Copy link
Contributor

@hashtagchris hashtagchris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for fixing this!

lib/commands/unpublish.js Show resolved Hide resolved
test/lib/commands/unpublish.js Show resolved Hide resolved
@wraithgar wraithgar merged commit 7b952f6 into latest Dec 1, 2023
20 checks passed
@wraithgar wraithgar deleted the gar/unpublish-package-json-errors branch December 1, 2023 19:44
@github-actions github-actions bot mentioned this pull request Dec 1, 2023
wraithgar added a commit that referenced this pull request Dec 1, 2023
If the file is there and there is any error that's always a show stopper
wraithgar added a commit that referenced this pull request Dec 1, 2023
If the file is there and there is any error that's always a show stopper
@github-actions github-actions bot mentioned this pull request Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants