Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: @npmcli/[email protected] [email protected] #4141

Merged
merged 1 commit into from
Dec 8, 2021
Merged

deps: @npmcli/[email protected] [email protected] #4141

merged 1 commit into from
Dec 8, 2021

Conversation

wraithgar
Copy link
Member

  • Fixes object property assignment bug in resolving package-locks with
    conflicts

@wraithgar wraithgar requested a review from a team as a code owner December 8, 2021 21:28
fritzy
fritzy approved these changes Dec 8, 2021
View reviewed changes
Copy link
Contributor

@fritzy fritzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

fritzy
fritzy approved these changes Dec 8, 2021
View reviewed changes
Copy link
Contributor

@fritzy fritzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wraithgar
deps: @npmcli/[email protected] [email protected]
e1da1fa 
* Fixes object property assignment bug in resolving package-locks with
  conflicts

PR-URL: #4141
Credit: @wraithgar
Close: #4141
Reviewed-by: @fritzy
@wraithgar wraithgar force-pushed the deps/arborist-parse-conflict-json branch from f464fc1 to e1da1fa Compare December 8, 2021 21:48
@wraithgar wraithgar merged commit e1da1fa into release-next Dec 8, 2021
@wraithgar wraithgar deleted the deps/arborist-parse-conflict-json branch December 8, 2021 21:48
@npm-robot
Copy link
Contributor

found 4 benchmarks with statistically significant performance improvements

  • app-large: modules-only, no-lock
  • app-medium: modules-only, no-lock
timing results
app-large clean lock-only cache-only cache-only
peer-deps		 modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@7 51.838 ±6.53 33.105 ±0.08 26.396 ±7.01 23.600 ±0.99 20.557 ±0.96 9.660 ±0.04 2.834 ±0.01 14.488 ±0.35 3.080 ±0.05 3.635 ±0.02
#4141 50.885 ±1.18 34.610 ±0.37 27.910 ±8.21 25.238 ±1.07 3.601 ±0.07 3.580 ±0.02 2.860 ±0.03 15.160 ±0.12 2.836 ±0.09 3.743 ±0.11
app-medium clean lock-only cache-only cache-only
peer-deps		 modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@7 36.562 ±0.51 25.500 ±0.16 15.316 ±0.15 16.099 ±0.50 17.452 ±0.36 8.381 ±0.20 2.888 ±0.03 10.676 ±0.14 2.704 ±0.02 3.247 ±0.04
#4141 38.561 ±0.40 27.343 ±0.27 16.313 ±0.09 17.486 ±0.13 3.341 ±0.07 3.202 ±0.01 3.009 ±0.07 11.247 ±0.17 2.713 ±0.04 3.438 ±0.02

@nlf nlf mentioned this pull request Dec 9, 2021
Merged
@npm-robot npm-robot mentioned this pull request Dec 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fritzy fritzy fritzy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wraithgar @npm-robot @fritzy