Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] npm version --no-git-tag-version doesn't work #1973

Closed
protyposis opened this issue Oct 16, 2020 · 3 comments
Closed

[BUG] npm version --no-git-tag-version doesn't work #1973

protyposis opened this issue Oct 16, 2020 · 3 comments
Assignees
Labels
Bug thing that needs fixing Release 7.x work is associated with a specific npm 7 release

Comments

@protyposis
Copy link

Current Behavior:

Executing npm version --no-git-tag-version creates a Git tag and a Git commit with the incremented version in package[-lock].json. Same behavior with --git-tag-version false and --git-tag-version=false.

Expected Behavior:

It only changes the version in package[-lock].json and does not create a Git commit/tag, as the docs suggest (https://github.com/npm/cli/blob/latest/docs/content/cli-commands/npm-version.md#git-tag-version), and like done by npm v6.

Steps To Reproduce:

  1. Enter the root directory of a package
  2. Execute npm version --no-git-tag-version patch
  3. Find version tag and commit in Git history

Environment:

  • OS: Windows 10, Ubuntu 18.04 (via WSLv1, Windows 10)
  • Node: 12.19.0, 12.13.0
  • npm: 7.0.1
@protyposis protyposis added Bug thing that needs fixing Needs Triage needs review for next steps Release 7.x work is associated with a specific npm 7 release labels Oct 16, 2020
@pablote
Copy link

pablote commented Oct 26, 2020

same here for macOS, reverted to npm 6.x.x fixed the issue for me

@nlf nlf removed the Needs Triage needs review for next steps label Oct 27, 2020
@nlf nlf self-assigned this Oct 27, 2020
@nlf
Copy link
Contributor

nlf commented Oct 27, 2020

we published 7.0.6 today that should resolve this, can you try updating with npm install -g npm@7 and let us know how it goes?

@protyposis
Copy link
Author

Confirming that it's resolved, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug thing that needs fixing Release 7.x work is associated with a specific npm 7 release
Projects
None yet
Development

No branches or pull requests

3 participants